Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove deprecated gcr.io/kubebuilder/kube-rbac-proxy-2.12.1 #2940

Closed
wants to merge 26 commits into from
Closed

chore: remove deprecated gcr.io/kubebuilder/kube-rbac-proxy-2.12.1 #2940

wants to merge 26 commits into from
+11 −5

Conversation

Venkat-Bramhasani
Copy link
Contributor

What problem does this PR solve?:
kube-rbac-proxy will get removed from gcr.io/kubebuilder registry

Which issue(s) does this PR fix?:
https://jira.nutanix.com/browse/NCN-104599

@github-actions github-actions bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 11, 2024
@github-actions github-actions bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 11, 2024
@github-actions github-actions bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 11, 2024
@Venkat-Bramhasani Venkat-Bramhasani self-assigned this Dec 11, 2024
@Venkat-Bramhasani Venkat-Bramhasani added the update-licenses signals mergebot to update licenses.d2iq.yaml label Dec 11, 2024
@github-actions github-actions bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 11, 2024
@github-actions github-actions bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 11, 2024
@github-actions github-actions bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 11, 2024
@github-actions github-actions bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 11, 2024
mhrabovcin
mhrabovcin reviewed Dec 11, 2024
View reviewed changes
licenses.d2iq.yaml Outdated Show resolved Hide resolved
mhrabovcin
mhrabovcin reviewed Dec 11, 2024
View reviewed changes
licenses.d2iq.yaml Outdated Show resolved Hide resolved
@mhrabovcin
Copy link
Contributor

@Venkat-Bramhasani in the license check you can see that 0.8.0 is coming from the kommander chart - https://github.com/mesosphere/kommander-applications/actions/runs/12282824073/job/34274888146?pr=2940#step:6:238

 + ./services/kommander-appmanagement/0.12.1/kommander-appmanagement.yaml

docker.io/mesosphere/kommander2-appmanagement-webhook:v2.12.1
docker.io/mesosphere/kommander2-appmanagement:v2.12.1
docker.io/mesosphere/kommander2-kubetools:v2.12.1
gcr.io/kubebuilder/kube-rbac-proxy:v0.8.0

This needs to be updated in the kommander repository. It would be sufficient to backport the https://github.com/mesosphere/kommander/pull/5223 PR to the release-2.12 and release-2.8 branches.

@github-actions github-actions bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 12, 2024
@Venkat-Bramhasani Venkat-Bramhasani added ok-to-test Signals mergebot that CI checks are ready to be kicked off and removed ok-to-test Signals mergebot that CI checks are ready to be kicked off labels Dec 12, 2024
@mhrabovcin
Copy link
Contributor

This change was handled in the kommander repo.

@mhrabovcin mhrabovcin closed this Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhrabovcin mhrabovcin mhrabovcin left review comments

Assignees

@Venkat-Bramhasani Venkat-Bramhasani

Labels
ok-to-test Signals mergebot that CI checks are ready to be kicked off services/git-operator services/kommander-appmanagement services/kube-prometheus-stack size/S Denotes a PR that changes 10-29 lines, ignoring generated files. update-licenses signals mergebot to update licenses.d2iq.yaml
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Venkat-Bramhasani @mhrabovcin @SandhyaRavi2403